Prepare for enhancement of Stake Manager contracts #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xPolygon#236) * build(deps-dev): bump @types/node from 20.1.1 to 20.1.3 Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 20.1.1 to 20.1.3. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * feat: implement mintable token predicate contracts (0xPolygon#234) * feat: add ERC20 mintable predicates * test: add tests for root mintable ERC20 predicate * fix: mintable root erc20 predicate fixes * test: implement tests for child mintable erc20 predicate * feat: implement root mintable ERC721 predicate * feat: implement child mintable erc721 predicate * test: implement child mintable erc721 tests * test: implement root mintable erc721 predicate tests * feat: implement child mintable erc1155 predicate * feat: implement root mintable erc1155 predicate * test: implement root mintable erc1155 predicate tests * chore: minor doc fixes, fix slither * build(deps-dev): bump @openzeppelin/hardhat-upgrades Bumps [@openzeppelin/hardhat-upgrades](https://github.com/OpenZeppelin/openzeppelin-upgrades) from 1.25.0 to 1.26.0. - [Release notes](https://github.com/OpenZeppelin/openzeppelin-upgrades/releases) - [Commits](https://github.com/OpenZeppelin/openzeppelin-upgrades/compare/@openzeppelin/[email protected]...@openzeppelin/[email protected]) --- updated-dependencies: - dependency-name: "@openzeppelin/hardhat-upgrades" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: qedk <[email protected]> Co-authored-by: Daniel Gretzke <[email protected]>
…storage gaps for these contracts
QEDK
suggested changes
Jul 4, 2023
…les now start with an underscore.
|
@drinkcoffee can you base your branch off |
I will aim to get that done on Monday. |
|
@drinkcoffee there is one remaining conflict, can you resolve that too, ty! |
|
I have re-merged origin/dev . I can't see any conflicts. Hopefully, it is now ready to merge. |
|
Are any future changes required? |
|
Slither and coverage would need to be fixed before merging into dev |
QEDK
approved these changes
Aug 2, 2023
|
I have fixed the slither issues. I am not sure how to fix the coverage issue "Error in plugin solidity-coverage: TypeError: provider.send is not a function". Looking at Stack Overflow, this appears to be a versioning issue between Hardhat and Solidity. |
|
thanks, I will merge and investigate myself |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prepares StakeManager for enhancement and upgrade. This PR: